OSSP CVS Repository

ossp - History for /ossp-pkg/xds/vencode.c
Not logged in
[Honeypot]  [Browse]  [Home]  [Login]  [Reports
[Search]  [Ticket]  [Timeline
  [Directory]  [Show Milestones

DateVersion Description
2001-Aug-08 21:15    1.15    Check-in [634]: First cut of the ruthless style adjustments to OSSP XDS:

o adjust source tree to follow OSSP source tree style by heavily combining sources into smaller sets (needs more work when still missing parts are added later)

o automatic re-indentation of sources with GNU indent (still needs manual review and adjustments; will follow)

These two heavy steps were mostly done automatically with the help of two helper scripts written in Perl. So expect more manual adjustments to follow... By rse.

2001-Aug-08 13:50    1.14    Check-in [4293]: Fixed warnings that complained about feeding a "char" into the isxxx() routines, which expect an "int". By simons. (diff)
2001-Aug-01 17:25    1.13    Check-in [591]: Merged the whole contents of branch "callback-semantic-rewrite" into the main branch. The changes there include:

- A change of the callback semantics; callbacks do now return XDS_ERR_(UNDER|OVER)FLOW in case the buffer size doesn't fit. Rather than passing the differing byte size through the return code, it is stored in the location used_buffer_size points to -- a new parameter provided to all callbacks.

   In order to implement this, the framework, all callbacks and most
   of the test suits had to be adapted.

- internal.h now provides the macro xds_check_parameter(), which can be used to verify the contents of function parameters with assert() and if in one line. If assert()s are deactivated, the routine will still return XDS_ERR_INVALID_ARG.

   Because of this change, internal.h now includes the system header
   assert.h. This means that this include coulde be removed from
   almost all modules.

- internal.h now provides the macros xds_init_(en|de)coding_engine(). These can be used to comfortably verify a callback's parameters and to verify the buffer size. All engines have been rewritten to use these. By simons.

2001-Aug-01 16:37    1.12.2.5    Check-in [4267] on branch callback-semantic-rewrite: - Make sure that used_buffer_size is initialized to zero before the callback is executed.

- Use used_buffer_size to determine the new size of the reallocated buffer in case of an overflow. If used_buffer_size is 0 (default), use 1 instead. By simons. (diff)

2001-Aug-01 15:26    1.12.2.4    Check-in [4265] on branch callback-semantic-rewrite: Now that internal.h includes assert.h we don't need to do that anymore. By simons. (diff)
2001-Aug-01 14:01    1.12.2.3    Check-in [4256] on branch callback-semantic-rewrite: Moved the code that enlarges the buffer in case it doesn't have any free space into the engine execution loop to make sure no engine is called with a "buffer_size" argument of 0. By simons. (diff)
2001-Aug-01 13:26    1.12.2.2    Check-in [4252] on branch callback-semantic-rewrite: Rewrote framework for new callback semantics: Callbacks now return an XDS_* code all the time. The length of the buffer used by the callback is returned via used_buffer_size. If the buffer is too small, XDS_ERR_OVERFLOW is returned. By simons. (diff)
2001-Aug-01 11:55    1.12.2.1    Check-in [4250] on branch callback-semantic-rewrite: Added xds_check_parameter() macro to short-cut the assert() and if-statements at the begining of every routine. Also rewrote some modules to take advantage of that macro. By simons. (diff)
2001-Jul-31 08:33    1.12    Check-in [4246]: Fixed three bugs revealed by RSE's review of the code. By simons. (diff)
2001-Jul-24 17:46    1.11    Check-in [4245]: xds_encode() and xds_decode() had two problems:

- In case any of the callbacks returns with an error, the original xds->buffer_len value must be restored or the buffer is messed up with values from successful callback executions. The routines wouldn't be atomic in that case.

- If an encoding callback uses up all buffer space but formatted the value successfully nonetheless, the xds->buffer_len wasn't incremented.

Both problems have been fixed. By simons. (diff)

2001-Jul-19 17:21    1.10    Check-in [4223]: Removed debug output. By simons. (diff)
2001-Jul-18 19:49    1.9    Check-in [4208]: Added XDS_TRUE and XDS_FALSE defines and started using them in the sources. By simons. (diff)
2001-Jul-18 19:38    1.8    Check-in [4207]: When an engine is restarted after buffer enlargement, the original value of the ap_list must be restored. Fixed that bug and added a test suite that verifies this behavior. By simons. (diff)
2001-Jul-16 20:31    1.7    Check-in [4201]: We need to make a difference between the callback using up all buffer capacity, in which case we need to enlarge the buffer but don't need to restart the callback, and the callback truncating its output, because the buffer was too small, in which case we need to enlarge the buffer and restart the callback. By simons. (diff)
2001-Jul-16 20:28    1.6    Check-in [4200]: Improved clarity of debug message. By simons. (diff)
2001-Jul-16 19:50    1.5    Check-in [4198]: Passing va_list parameters by value is fine, unless the called routine modifies the parameter list and you expect the change to propagate back to the mother routine. What is what we want. Hence, I changed the prototype of the engine callback to expect a pointer to va_list. By simons. (diff)
2001-Jul-09 19:44    1.4    Check-in [4186]: Removed two instances where a local definition of "rc" shadowed an earlier one in the routine. By simons. (diff)
2001-Jul-09 19:36    1.3    Check-in [4185]: Fixed a bug in xds_vencode() that would cause the routine not to recognize the end of the fmt string correctly. By simons. (diff)
2001-Jul-09 19:19    1.2    Check-in [4179]: Implemented xds_encode() and xds_vencode(). By simons. (diff)
2001-Jul-04 17:58    1.1    Check-in [4144]: Added function stubs that return errors when called. By simons.

CVSTrac 2.0.1