|
Check-in Number:
|
4198 | |
| Date: |
2001-Jul-16 19:50:07 (local)
2001-Jul-16 17:50:07 (UTC) |
| User: | simons |
| Branch: | |
| Comment: |
Passing va_list parameters by value is fine, unless the called routine
modifies the parameter list and you expect the change to propagate
back to the mother routine. What is what we want. Hence, I changed the
prototype of the engine callback to expect a pointer to va_list. |
| Tickets: |
|
| Inspections: |
|
| Files: |
|
ossp-pkg/xds/regression-tests/xds-decode.c 1.1 -> 1.2
--- xds-decode.c 2001/07/09 19:09:42 1.1
+++ xds-decode.c 2001/07/16 17:50:08 1.2
@@ -29,7 +29,7 @@
#include <string.h>
#include "../internal.h"
-static int dummy_engine(xds_t* xds, void* engine_context, void* buffer, size_t buffer_size, va_list args)
+static int dummy_engine(xds_t* xds, void* engine_context, void* buffer, size_t buffer_size, va_list* args)
{
if (xds == NULL)
{
|
|
ossp-pkg/xds/regression-tests/xds-encode.c 1.3 -> 1.4
--- xds-encode.c 2001/07/09 19:10:06 1.3
+++ xds-encode.c 2001/07/16 17:50:08 1.4
@@ -29,7 +29,7 @@
#include <string.h>
#include "../internal.h"
-static int dummy_engine(xds_t* xds, void* engine_context, void* buffer, size_t buffer_size, va_list args)
+static int dummy_engine(xds_t* xds, void* engine_context, void* buffer, size_t buffer_size, va_list* args)
{
if (xds == NULL)
{
|
|
ossp-pkg/xds/regression-tests/xds-getbuffer.c 1.2 -> 1.3
--- xds-getbuffer.c 2001/07/09 19:10:06 1.2
+++ xds-getbuffer.c 2001/07/16 17:50:08 1.3
@@ -29,7 +29,7 @@
#include <string.h>
#include "../internal.h"
-static int dummy_engine(xds_t* xds, void* engine_context, void* buffer, size_t buffer_size, va_list args)
+static int dummy_engine(xds_t* xds, void* engine_context, void* buffer, size_t buffer_size, va_list* args)
{
strncpy(buffer, "Hallo!", buffer_size);
return 6;
|
|
ossp-pkg/xds/regression-tests/xds-register.c 1.5 -> 1.6
--- xds-register.c 2001/07/09 19:10:06 1.5
+++ xds-register.c 2001/07/16 17:50:08 1.6
@@ -30,7 +30,7 @@
#include <assert.h>
#include "../internal.h"
-static int dummy_engine(xds_t* xds, void* engine_context, void* buffer, size_t buffer_size, va_list args)
+static int dummy_engine(xds_t* xds, void* engine_context, void* buffer, size_t buffer_size, va_list* args)
{
return 0;
}
|
|
ossp-pkg/xds/vdecode.c 1.2 -> 1.3
--- vdecode.c 2001/07/09 19:00:44 1.2
+++ vdecode.c 2001/07/16 17:50:07 1.3
@@ -76,7 +76,7 @@
xds->engines[pos].context,
xds->buffer + xds->buffer_len,
xds->buffer_capacity - xds->buffer_len,
- args);
+ &args);
if (rc < 0)
goto leave;
else
|
|
ossp-pkg/xds/vencode.c 1.4 -> 1.5
--- vencode.c 2001/07/09 17:44:29 1.4
+++ vencode.c 2001/07/16 17:50:07 1.5
@@ -115,7 +115,7 @@
xds->engines[pos].context,
xds->buffer + xds->buffer_len,
xds->buffer_capacity - xds->buffer_len,
- args);
+ &args);
if (rc < 0)
goto leave;
else if (rc >= xds->buffer_capacity - xds->buffer_len)
|
|
ossp-pkg/xds/xds.h 1.15 -> 1.16
--- xds.h 2001/07/09 19:00:44 1.15
+++ xds.h 2001/07/16 17:50:07 1.16
@@ -54,7 +54,7 @@
void* engine_context,
void* buffer,
size_t buffer_size,
- va_list args);
+ va_list* args);
xds_t* xds_init(xds_mode_t);
void xds_destroy(xds_t* xds);
|
|
