OSSP CVS Repository

ossp - Check-in [974]
Not logged in
[Honeypot]  [Browse]  [Home]  [Login]  [Reports
[Search]  [Ticket]  [Timeline
  [Patchset]  [Tagging/Branching

Check-in Number: 974
Date: 2001-Sep-13 13:58:05 (local)
2001-Sep-13 11:58:05 (UTC)
User:ms
Branch:
Comment: Check that an incoming level argument is given, but only check arguments once - in l2_stream_vlog where it counts.
Tickets:
Inspections:
Files:
ossp-pkg/l2/l2_stream.c      1.16 -> 1.17     1 inserted, 5 deleted

ossp-pkg/l2/l2_stream.c 1.16 -> 1.17

--- l2_stream.c  2001/09/12 13:50:46     1.16
+++ l2_stream.c  2001/09/13 11:58:05     1.17
@@ -128,10 +128,6 @@
     va_list ap;
     l2_result_t rv;
 
-    /* argument sanity check */
-    if (st == NULL || level == 0 || fmt == NULL)
-        return L2_ERR_ARG;
-
     /* pass-through to va_list-based variant */
     va_start(ap, fmt);
     rv = l2_stream_vlog(st, level, fmt, ap);
@@ -188,7 +184,7 @@
     l2_util_format_t vfmt;
 
     /* argument sanity check */
-    if (st == NULL || fmt == NULL || ap == NULL)
+    if (st == NULL || level == 0 || fmt == NULL || ap == NULL)
         return L2_ERR_ARG;
 
     /* make sure only a single level is specified */

CVSTrac 2.0.1