OSSP CVS Repository

ossp - Check-in [3001]
Not logged in
[Honeypot]  [Browse]  [Home]  [Login]  [Reports
[Search]  [Ticket]  [Timeline
  [Patchset]  [Tagging/Branching

Check-in Number: 3001
Date: 2002-Dec-21 12:24:17 (local)
2002-Dec-21 11:24:17 (UTC)
User:rse
Branch:
Comment: Fix incorrect use (and hence producing a warning for uninitialized variable) of variables in the writing of history files.
Tickets:
Inspections:
Files:
ossp-pkg/shiela/ChangeLog      1.16 -> 1.17     4 inserted, 0 deleted
ossp-pkg/shiela/shiela.pl      1.21 -> 1.22     2 inserted, 3 deleted

ossp-pkg/shiela/ChangeLog 1.16 -> 1.17

--- ChangeLog    2002/12/21 11:00:17     1.16
+++ ChangeLog    2002/12/21 11:24:17     1.17
@@ -11,6 +11,10 @@
 
   Changes between 0.9.2 and 0.9.3 (19-Aug-2002 to 21-Dec-2002):
 
+   *) Fix incorrect use (and hence producing a warning for uninitialized
+      variable) of variables in the writing of history files.
+      [Ralf S. Engelschall]
+
    *) Finally really use the "Environment" configuration section to find
       "cvs" and "sendmail" directly and add a "Program" sub-command to it
       for easier extension of the "Environment" section in the future.


ossp-pkg/shiela/shiela.pl 1.21 -> 1.22

--- shiela.pl    2002/12/21 11:00:17     1.21
+++ shiela.pl    2002/12/21 11:24:17     1.22
@@ -841,8 +841,7 @@
 sub history_save {
     my ($PA, $RT, $CF, $IN) = @_;
     my $O = '';
-    my $file;
-    foreach $file (keys(%{$IN->{file}})) {
+    foreach my $file (keys(%{$IN->{file}})) {
         my $e = $IN->{file}->{$file};
         $O .= $IN->{handle};
         $O .= ",$file";
@@ -856,7 +855,7 @@
         $O .= "\n";
     }
     my $io = new IO::File ">>".$RT->{historydb}
-         || die "cannot store information to history db `$file'";
+         || die "cannot store information to history db `$RT->{historydb}'";
     $io->print($O);
     $io->close;
     return;

CVSTrac 2.0.1