OSSP CVS Repository

Ticket 116: make install installs libtool wrapper-script instead of js binary

--- Makefile.in.old     2006-07-31 15:26:17.000000000 +0200
+++ Makefile.in 2006-07-31 15:30:14.000000000 +0200
@@ -181,7 +181,6 @@
        $(SHTOOL) mkdir -f -p -m 755 $(DESTDIR)$(mandir)/man3
        $(SHTOOL) mkdir -f -p -m 755 $(DESTDIR)$(includedir)/js
        $(SHTOOL) mkdir -f -p -m 755 $(DESTDIR)$(libdir)/pkgconfig
-       $(SHTOOL) install -c -m 755 js $(DESTDIR)$(bindir)/
        $(SHTOOL) install -e 's;#!\./js;#!$(bindir)/js;' -c -m 755 jslint.js $(DESTDIR)$(bindir)/jslint
        $(SHTOOL) install -c -m 644 js.1 $(DESTDIR)$(mandir)/man1/
        $(SHTOOL) install -c -m 644 js.3 $(DESTDIR)$(mandir)/man3/
@@ -192,6 +191,7 @@
        @if [ ".$(WITH_PERL)" = ".yes" ]; then \
            (cd src/perlconnect; $(MAKE) $(MFLAGS) install DESTDIR=$(DESTDIR)); \
        fi
+       @$(LIBTOOL) --mode=install $(SHTOOL) install -c -m 755 js $(DESTDIR)$(bindir)/

 .PHONY: clean
 clean:

[Append remarks]

Remarks:

Ops, really a great catch! I'm always building without shared libraries and then libtool doesn't create the wrapper script. So this situation never occurred for me. Many thanks for catching this.

[Append remarks]

Properties:

Type:	code		Version:	1.6.20060730
Status:	fixed		Created:	2006-Jul-31 15:35
Severity:	1		Last Change:	2006-Jul-31 19:32
Priority:	1		Subsystem:	js
Assigned To:	rse		Derived From:
Creator:	anonymous

Related Check-ins:

2006-Jul-31 19:32

•

Check-in [5620]: Fix "make install": the executable "js" was not installed via GNU libtool and this way under --enable-shared the wrapper script was installed only. Submitted by: Alfred Reibenschuh <alfred.reibenschuh@it-austria.com> (By rse)