OSSP CVS Repository

Ticket 92 History: uuid-1.4.1 PHP 4 interface

1. Created 2006-Mar-03 13:01:52 by anonymous
2. Change status from "new" to "review" by rse on 2006-May-11 20:41
3. Added remarks:

   Hmmm... the third_arg_force_ref for uuid_create() was a mistake, yes. Fixed. But I like to keep the API as close to the C API as possible (although I know that this way it isn't the most elegant PHP API, of course). Additionally, I do not get these errors, neither with PHP 4 nor PHP 5. Do I have to enable some warnings somewhere? I'm not a PHP expert...

   by rse on 2006-May-11 20:41
4. Appended to remarks:

   ---

   2006-Jun-08 14:01:06 by anonymous:
   Use php.ini-recommended or set

     error_reporting = E_ALL
     allow_call_time_pass_reference = Off
   

   I understand your desire to keep the interfaces as close as possible, but PHP is not C. Current code maintains superficial similarity, but the things are not the same.

   Declaring a function with byval parameters, and then sometimes calling it with byref is bad style in PHP, and has been suggested against since I remember. Matters of taste aside, the urge to produce library code that's silent with E_ALL is very strong in PHP because of bad interactions with custom error handlers, debuggers, etc.

   BTW, thanks for committing #93.

   by anonymous on 2006-Jun-08 14:01