Index: ossp-pkg/lmtp2nntp/00TODO RCS File: /v/ossp/cvs/ossp-pkg/lmtp2nntp/00TODO,v rcsdiff -q -kk '-r1.16' '-r1.17' -u '/v/ossp/cvs/ossp-pkg/lmtp2nntp/00TODO,v' 2>/dev/null --- 00TODO 2001/08/27 13:45:53 1.16 +++ 00TODO 2001/08/27 14:29:11 1.17 @@ -1,21 +1,14 @@ -M=NNNN im Sendmail ergaenzen (weil Postfix gar nix hat) durch --l Commandline options fuer Maximum Message Size - +M=NNNN im Sendmail ergaenzen (weil Postfix gar nix hat) durch -l Commandline options fuer Maximum Message Size use "RFC1918-like" private Domainnames for @example.com (check which name is registered) whatsup draufleiten dmalloc -FIXMEs -DEBUGs RFC1891 ENVID RFC1891 6.2 -FALSE, TRUE vs. == FALSE, == TRUE, != FALSE, != TRUE -h needs to understand multiple hosts as comma separated list NUL statt '\0' ID logging problem - -lmtp_response segfaults when a physical line ('\n' terminated) of the logical -line input exceeds LMTP_LINE_MAXLEN. +lmtp_response segfaults when a physical line ('\n' terminated) of the logical line input exceeds LMTP_LINE_MAXLEN. **** LMTP REDESIGN **** Index: ossp-pkg/lmtp2nntp/lmtp2nntp.c RCS File: /v/ossp/cvs/ossp-pkg/lmtp2nntp/Attic/lmtp2nntp.c,v rcsdiff -q -kk '-r1.28' '-r1.29' -u '/v/ossp/cvs/ossp-pkg/lmtp2nntp/Attic/lmtp2nntp.c,v' 2>/dev/null --- lmtp2nntp.c 2001/08/27 14:25:33 1.28 +++ lmtp2nntp.c 2001/08/27 14:29:11 1.29 @@ -298,7 +298,6 @@ } /* remaining arguments are Groupargs */ for (i = optind; i < argc; i++) { - /*fprintf(stderr, "DEBUG: argv[i] = ***%s***\n", argv[i]); */ argz_add(&ctx->azGroupargs, &ctx->asGroupargs, argv[i]); } @@ -433,16 +432,13 @@ do { bOk = TRUE; if (connect(ctx->ns[i].s, ctx->ns[i].sa->sa_buf, ctx->ns[i].sa->sa_len) < 0) { - /*fprintf(stderr, "DEBUG: connect failed: %s\n", strerror(errno)); */ bOk = FALSE; } if (bOk && ((ctx->ns[i].nntp = nntp_create(ctx->ns[i].s, ctx->ns[i].s, ctx->option_tracing ? &nntp_io : NULL)) == NULL)) { - /*fprintf(stderr, "DEBUG: nntp_create failed: %s\n", strerror(errno)); */ bOk = FALSE; } if (bOk && ((rc = nntp_init(ctx->ns[i].nntp)) != NNTP_OK)) { - /*fprintf(stderr, "DEBUG: nntp_init failed: %s\n", nntp_error(rc)); */ bOk = FALSE; } if (bOk) @@ -975,13 +971,6 @@ } } -#if 0 /*DEBUG and LOGGING paragraph */ - rcpt = NULL; - while ((rcpt = argz_next(ctx->msg->azNewsgroups, ctx->msg->asNewsgroups, rcpt)) != NULL) { - fprintf(stderr, "DEBUG: commited group ***%s***\n", rcpt); - } -#endif - /* RFC0821 4.2.1. REPLY CODES BY FUNCTION GROUPS 554 Transaction failed * RFC1893 2. Status Codes 5.X.X Permanent Failure * RFC1893 3.5 Network and Routing Status X.6.5 Conversion Failed @@ -997,11 +986,9 @@ } return LMTP_OK; } - /*fprintf(stderr, "DEBUG: after msg_join\n"); */ bSuccess = NNTP_EOF; /* assume a hard error for the worst case */ for (i = 0; i < ctx->nsc; i++) { - /*fprintf(stderr, "DEBUG: trying service %s\n", ctx->ns[i].h); */ switch (ctx->option_deliverymode) { case DELIVERYMODE_FAKE: break; Index: ossp-pkg/lmtp2nntp/msg.c RCS File: /v/ossp/cvs/ossp-pkg/lmtp2nntp/Attic/msg.c,v rcsdiff -q -kk '-r1.10' '-r1.11' -u '/v/ossp/cvs/ossp-pkg/lmtp2nntp/Attic/msg.c,v' 2>/dev/null --- msg.c 2001/08/27 13:45:53 1.10 +++ msg.c 2001/08/27 14:29:11 1.11 @@ -159,7 +159,6 @@ if (msg->cpMsgid != NULL) return MSG_ERR_SPLITIDMULTI; argz_delete(&msg->azHeaders, &msg->asHeaders, cp); /* del name */ - /*fprintf(stderr, "DEBUG: Message-ID cp = ***%s***\n", cp); */ if ((cp == NULL) || (strlen(cp) == 0)) /* get value */ return MSG_ERR_SPLITIDEMPTY; if ((msg->cpMsgid = strdup(cp)) == NULL) @@ -169,7 +168,6 @@ } if (strcasecmp("Newsgroups:", cp) == 0) { argz_delete(&msg->azHeaders, &msg->asHeaders, cp); /* del name */ - /*fprintf(stderr, "DEBUG: Newsgroups cp = ***%s***\n", cp); */ if (argz_add(&msg->azNewsgroups, &msg->asNewsgroups, cp) != 0) /* get value */ return MSG_ERR_MEM; argz_delete(&msg->azHeaders, &msg->asHeaders, cp); /* del value */ @@ -212,7 +210,6 @@ if (msg->azNewsgroups == NULL) return MSG_ERR_JOINGROUPNONE; argz_stringify(msg->azNewsgroups, msg->asNewsgroups, ','); - /*fprintf(stderr, "DEBUG: join consolidated azNewsgroups = ***%s***\n", msg->azNewsgroups); */ if (strlen(msg->azNewsgroups) == 0) return MSG_ERR_JOINGROUPEMPTY; argz_add(&msg->azHeaders, &msg->asHeaders, "Newsgroups:"); @@ -371,7 +368,6 @@ msg->cpMsg[n++] = '\n'; msg->cpMsg[n] = '\0'; - /*fprintf(stderr, "DEBUG: Message = ***%s***\n", msg->cpMsg); */ return MSG_OK; } Index: ossp-pkg/lmtp2nntp/nntp.c RCS File: /v/ossp/cvs/ossp-pkg/lmtp2nntp/Attic/nntp.c,v rcsdiff -q -kk '-r1.16' '-r1.17' -u '/v/ossp/cvs/ossp-pkg/lmtp2nntp/Attic/nntp.c,v' 2>/dev/null --- nntp.c 2001/08/27 14:25:33 1.16 +++ nntp.c 2001/08/27 14:29:11 1.17 @@ -131,24 +131,19 @@ do { if ((rc = nntp_readline(nntp, line, sizeof(line))) != NNTP_OK) { - /*fprintf(stderr, "DEBUG: nntp_readline returned ***%d***\n", rc); */ return rc; } } while (line[0] == '1'); - /*fprintf(stderr, "DEBUG: nntp_readline got ***%s***\n", line); */ - /* prepare for the INN kludge using 441 returns for other things but * "Duplicate". Typical welcome string is "200 host InterNetNews NNRP * server INN 2.3.2 ready (posting * ok)." */ if (strncmp(line, "200", 3) == 0 && strstr(line, " INN ") != NULL) { nntp->kludgeinn441dup = TRUE; - /*fprintf(stderr, "DEBUG: INN kludge activated!\n"); */ } else { nntp->kludgeinn441dup = FALSE; - /*fprintf(stderr, "DEBUG: no INN kludge!\n"); */ } if (strncmp(line, "200", 3) == 0) @@ -212,7 +207,6 @@ buf[n] = '\0'; /* string termination */ if (n == (buflen-1)) return NNTP_ERR_OVERFLOW; - /*fprintf(stderr, "DEBUG: nntp_readline <<<%s\n", buf); */ return NNTP_OK; } @@ -224,7 +218,6 @@ return NNTP_ERR_ARG; strncpy(tmp, buf, NNTP_LINE_MAXLEN-3); strcat(tmp, "\r\n"); - /*fprintf(stderr, "DEBUG: nntp_writeline >>>%s", tmp); */ if (nntp->io.write(nntp->wfd, tmp, strlen(tmp)) < 0) return NNTP_ERR_SYSTEM; return NNTP_OK; @@ -342,7 +335,6 @@ if ((rc = nntp_readline(nntp, line, sizeof(line))) != NNTP_OK) return rc; - /*fprintf(stderr, "DEBUG: answer to post = ***%s***, rc = %s\n", line, nntp_error(rc)); */ if (strncmp(line, "240", 3) == 0) return NNTP_OK; @@ -419,7 +411,6 @@ if ((rc = nntp_readline(nntp, line, sizeof(line))) != NNTP_OK) return rc; - /*fprintf(stderr, "DEBUG: answer to post = ***%s***, rc = %s\n", line, nntp_error(rc)); */ if (strncmp(line, "235", 3) == 0) return NNTP_OK;