OSSP CVS Repository

ossp - Check-in [874]
Not logged in
[Honeypot]  [Browse]  [Home]  [Login]  [Reports
[Search]  [Ticket]  [Timeline
  [Patchset]  [Tagging/Branching

Check-in Number: 874
Date: 2001-Sep-06 16:43:25 (local)
2001-Sep-06 14:43:25 (UTC)
User:rse
Branch:
Comment: It is fully legal to have some handler operations not implemented in case there is nothing to do for the handler. So remove the No-op hooks.
Tickets:
Inspections:
Files:
ossp-pkg/l2/l2_ch_file.c      1.14 -> 1.15     1 inserted, 9 deleted
ossp-pkg/l2/l2_ch_socket.c      1.14 -> 1.15     1 inserted, 9 deleted
ossp-pkg/l2/l2_ch_syslog.c      1.15 -> 1.16     1 inserted, 9 deleted

ossp-pkg/l2/l2_ch_file.c 1.14 -> 1.15

--- l2_ch_file.c 2001/09/06 14:37:53     1.14
+++ l2_ch_file.c 2001/09/06 14:43:25     1.15
@@ -124,14 +124,6 @@
     return L2_OK;
 }
 
-/* flush channel */
-static l2_result_t hook_flush(l2_context_t *ctx, l2_channel_t *ch)
-{
-    /* NOP for this channel, because Unix I/O files are unbuffered! */
-
-    return L2_OK;
-}
-
 /* close channel */
 static l2_result_t hook_close(l2_context_t *ctx, l2_channel_t *ch)
 {
@@ -170,7 +162,7 @@
     hook_configure,
     hook_open,
     hook_write,
-    hook_flush,
+    NULL,
     hook_close,
     hook_destroy
 };


ossp-pkg/l2/l2_ch_socket.c 1.14 -> 1.15

--- l2_ch_socket.c       2001/09/06 14:37:53     1.14
+++ l2_ch_socket.c       2001/09/06 14:43:25     1.15
@@ -271,14 +271,6 @@
     return L2_OK;
 }
 
-/* flush channel */
-static l2_result_t hook_flush(l2_context_t *ctx, l2_channel_t *ch)
-{
-    /* NOP for this channel, because Unix I/O sockets are unbuffered! */
-
-    return L2_OK;
-}
-
 /* close channel */
 static l2_result_t hook_close(l2_context_t *ctx, l2_channel_t *ch)
 {
@@ -317,7 +309,7 @@
     hook_configure,
     hook_open,
     hook_write,
-    hook_flush,
+    NULL,
     hook_close,
     hook_destroy
 };


ossp-pkg/l2/l2_ch_syslog.c 1.15 -> 1.16

--- l2_ch_syslog.c       2001/09/06 14:37:53     1.15
+++ l2_ch_syslog.c       2001/09/06 14:43:25     1.16
@@ -117,14 +117,6 @@
     return L2_OK;
 }
 
-/* flush channel */
-static l2_result_t hook_flush(l2_context_t *ctx, l2_channel_t *ch)
-{
-    /* Noop for this channel, because syslog entries are unbuffered */
-
-    return L2_OK;
-}
-
 /* close channel */
 static l2_result_t hook_close(l2_context_t *ctx, l2_channel_t *ch)
 {
@@ -160,7 +152,7 @@
     hook_configure,
     hook_open,
     hook_write,
-    hook_flush,
+    NULL,
     hook_close,
     hook_destroy
 };

CVSTrac 2.0.1