|
Check-in Number:
|
785 | |
| Date: |
2001-Aug-28 16:27:35 (local)
2001-Aug-28 14:27:35 (UTC) |
| User: | thl |
| Branch: | |
| Comment: |
the MAIL and DATA callbacks checked for information no longer available after
we proper free the structure containing this data. Now rewritten to first
check for existence of structure then look into the structure; segfault fixed;
00TODO updated; long line test file renamed and long lines removed from normal
test suite; |
| Tickets: |
|
| Inspections: |
|
| Files: |
|
ossp-pkg/lmtp2nntp/00TODO 1.19 -> 1.20
--- 00TODO 2001/08/28 13:12:58 1.19
+++ 00TODO 2001/08/28 14:27:35 1.20
@@ -6,7 +6,6 @@
RFC1891 6.2
ID logging problem
lmtp_response segfaults when a physical line ('\n' terminated) of the logical line input exceeds LMTP_LINE_MAXLEN.
-something segfaults when NNTP unreachable data with very long lines is read as commands
manpage header reads "User Contributed Perl Documentation" - Perl!?
**** LMTP REDESIGN ****
|
|
ossp-pkg/lmtp2nntp/lmtp2nntp.c 1.32 -> 1.33
--- lmtp2nntp.c 2001/08/28 13:12:58 1.32
+++ lmtp2nntp.c 2001/08/28 14:27:35 1.33
@@ -176,7 +176,7 @@
ctx->asGroupargs = 0;
initsession(&ctx->session);
ctx->msg = NULL;
- if (uname(&ctx->uname) != 0) {
+ if (uname(&ctx->uname) == -1) {
fprintf(stderr, "%s:Error: uname failed \"%s\"\n", progname, strerror(errno));
exit(ERR_EXECUTION);
}
@@ -755,7 +755,7 @@
* RFC1893 2. Status Codes 5.X.X Permanent Failure
* RFC1893 3.5 Network and Routing Status X.5.0 Other or undefined protocol status
*/
- if (ctx->msg->mail_from == NULL) {
+ if ((ctx->msg == NULL) || (ctx->msg->mail_from == NULL)) {
res.statuscode = "503";
res.dsncode = "5.5.0";
res.statusmsg = "specify sender with MAIL first.";
@@ -858,7 +858,7 @@
* RFC1893 2. Status Codes 5.X.X Permanent Failure
* RFC1893 3.5 Network and Routing Status X.5.0 Other or undefined protocol status
*/
- if (argz_count(ctx->msg->azRcpt, ctx->msg->asRcpt) == 0) {
+ if ((ctx->msg == NULL) || (argz_count(ctx->msg->azRcpt, ctx->msg->asRcpt) == 0)) {
res.statuscode = "503";
res.dsncode = "5.5.0";
res.statusmsg = "specify recipient with RCPT first.";
|
|
ossp-pkg/lmtp2nntp/test/testmessage.foldlinesvialmtp -> 1.1
*** /dev/null Sat Nov 23 00:55:02 2024
--- - Sat Nov 23 00:55:56 2024
***************
*** 0 ****
--- 1,24 ----
+ LHLO dev.de.cw.net
+ MAIL From:<thl@dev.de.cw.net>
+ RCPT To:<cw.de.sd.apps.dev.test@news-posting>
+ RCPT To:<foo.bar@news-posting>
+ RCPT To:<foo.test.bar@news-posting>
+ DATA
+ Date: Tue, 26 Aug 2001 14:51:48 +0200 (CEST)
+ Message-Id: <200108141251.f7ECpmn74812@dev.de.cw.net>
+ From: Thomas Lotterer <Thomas.Lotterer@de.cw.net>
+ X-Wraptest1: 0123456789 0123456789 0123456789 0123456789 0123456789 0123456789 0123456789 0123456789 0123456789 0123456789 0123456789 0123456789 0123456789 0123456789 0123456789 0123456789 0123456789 0123456789 0123456789 0123456789
+ X-Wraptest2: 01234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789
+ X-Wraptest3: the quick brown fox jumps over the lazy dog. THE QUICK BROWN FOX JUMPS OVER THE LAZY DOG. the quick brown fox jumps over the lazy dog. THE QUICK BROWN FOX JUMPS OVER THE LAZY DOG. the quick brown fox jumps over the lazy dog. THE QUICK BROWN FOX JUMPS OVER THE LAZY DOG. the quick brown fox jumps over the lazy dog. THE QUICK BROWN FOX JUMPS OVER THE LAZY DOG. the quick brown fox jumps over the lazy dog. THE QUICK BROWN FOX JUMPS OVER THE LAZY DOG. the quick brown fox jumps over the lazy dog. THE QUICK BROWN FOX JUMPS OVER THE LAZY DOG. the quick brown fox jumps over the lazy dog. THE QUICK BROWN FOX JUMPS OVER THE LAZY DOG!
+ X-Wraptest4: thequickbrownfoxjumpsoverthelazydog.THEQUICKBROWNFOXJUMPSOVERTHELAZYDOG.thequickbrownfoxjumpsoverthelazydog.THEQUICKBROWNFOXJUMPSOVERTHELAZYDOG.thequickbrownfoxjumpsoverthelazydog.THEQUICKBROWNFOXJUMPSOVERTHELAZYDOG.thequickbrownfoxjumpsoverthelazydog.THEQUICKBROWNFOXJUMPSOVERTHELAZYDOG.thequickbrownfoxjumpsoverthelazydog.THEQUICKBROWNFOXJUMPSOVERTHELAZYDOG.thequickbrownfoxjumpsoverthelazydog.THEQUICKBROWNFOXJUMPSOVERTHELAZYDOG.thequickbrownfoxjumpsoverthelazydog.THEQUICKBROWNFOXJUMPSOVERTHELAZYDOG!
+ X-Wraptest5: the quick brown fox jumps over the lazy dog. THE QUICK BROWN FOX JUMPS OVER THE LAZY DOG. the quick brown fox jumps over the lazy dog. THE QUICK BROWN FOX JUMPS OVER THE LAZY DOG. the quick brown fox jumps over the lazy dog. THE QUICK BROWN FOX JUMPS OVER THE LAZY DOG. the quick brown fox jumps over the lazy dog. THE QUICK BROWN FOX JUMPS OVER THE LAZY DOG. the quick brown fox jumps over the lazy dog. THE QUICK BROWN FOX JUMPS OVER THE LAZY DOG. the quick brown fox jumps over the lazy dog. THE QUICK BROWN FOX JUMPS OVER THE LAZY DOG. the quick brown fox jumps over the lazy dog. THE QUICK BROWN FOX JUMPS OVER THE LAZY DOG!
+ X-Wraptest6: the quick brown fox jumps over the lazy dog. THE QUICK BROWN FOX JUMPS OVER THE LAZY DOG. the quick brown fox jumps over the lazy dog. THE QUICK BROWN FOX JUMPS OVER THE LAZY DOG. the quick brown fox jumps over the lazy dog. THE QUICK BROWN FOX JUMPS OVER THE LAZY DOG. the quick brown fox jumps over the lazy dog. THE QUICK BROWN FOX JUMPS OVER THE LAZY DOG. the quick brown fox jumps over the lazy dog. THE QUICK BROWN FOX JUMPS OVER THE LAZY DOG. the quick brown fox jumps over the lazy dog. THE QUICK BROWN FOX JUMPS OVER THE LAZY DOG. the quick brown fox jumps over the lazy dog. THE QUICK BROWN FOX JUMPS OVER THE LAZY DOG!
+ Subject: lmtp2nntp testmessage.viasendmail
+
+ ..
+ a dot above
+ #
+ a dot below
+ ..
+ .
+ QUIT
|
|
ossp-pkg/lmtp2nntp/test/testmessage.vialmtp 1.3 -> 1.4
--- testmessage.vialmtp 2001/08/27 13:45:53 1.3
+++ testmessage.vialmtp 2001/08/28 14:27:35 1.4
@@ -7,12 +7,6 @@
Date: Tue, 26 Aug 2001 14:51:48 +0200 (CEST)
Message-Id: <200108141251.f7ECpmn74812@dev.de.cw.net>
From: Thomas Lotterer <Thomas.Lotterer@de.cw.net>
-X-Wraptest1: 0123456789 0123456789 0123456789 0123456789 0123456789 0123456789 0123456789 0123456789 0123456789 0123456789 0123456789 0123456789 0123456789 0123456789 0123456789 0123456789 0123456789 0123456789 0123456789 0123456789
-X-Wraptest2: 01234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789
-X-Wraptest3: the quick brown fox jumps over the lazy dog. THE QUICK BROWN FOX JUMPS OVER THE LAZY DOG. the quick brown fox jumps over the lazy dog. THE QUICK BROWN FOX JUMPS OVER THE LAZY DOG. the quick brown fox jumps over the lazy dog. THE QUICK BROWN FOX JUMPS OVER THE LAZY DOG. the quick brown fox jumps over the lazy dog. THE QUICK BROWN FOX JUMPS OVER THE LAZY DOG. the quick brown fox jumps over the lazy dog. THE QUICK BROWN FOX JUMPS OVER THE LAZY DOG. the quick brown fox jumps over the lazy dog. THE QUICK BROWN FOX JUMPS OVER THE LAZY DOG. the quick brown fox jumps over the lazy dog. THE QUICK BROWN FOX JUMPS OVER THE LAZY DOG!
-X-Wraptest4: thequickbrownfoxjumpsoverthelazydog.THEQUICKBROWNFOXJUMPSOVERTHELAZYDOG.thequickbrownfoxjumpsoverthelazydog.THEQUICKBROWNFOXJUMPSOVERTHELAZYDOG.thequickbrownfoxjumpsoverthelazydog.THEQUICKBROWNFOXJUMPSOVERTHELAZYDOG.thequickbrownfoxjumpsoverthelazydog.THEQUICKBROWNFOXJUMPSOVERTHELAZYDOG.thequickbrownfoxjumpsoverthelazydog.THEQUICKBROWNFOXJUMPSOVERTHELAZYDOG.thequickbrownfoxjumpsoverthelazydog.THEQUICKBROWNFOXJUMPSOVERTHELAZYDOG.thequickbrownfoxjumpsoverthelazydog.THEQUICKBROWNFOXJUMPSOVERTHELAZYDOG!
-X-Wraptest5: the quick brown fox jumps over the lazy dog. THE QUICK BROWN FOX JUMPS OVER THE LAZY DOG. the quick brown fox jumps over the lazy dog. THE QUICK BROWN FOX JUMPS OVER THE LAZY DOG. the quick brown fox jumps over the lazy dog. THE QUICK BROWN FOX JUMPS OVER THE LAZY DOG. the quick brown fox jumps over the lazy dog. THE QUICK BROWN FOX JUMPS OVER THE LAZY DOG. the quick brown fox jumps over the lazy dog. THE QUICK BROWN FOX JUMPS OVER THE LAZY DOG. the quick brown fox jumps over the lazy dog. THE QUICK BROWN FOX JUMPS OVER THE LAZY DOG. the quick brown fox jumps over the lazy dog. THE QUICK BROWN FOX JUMPS OVER THE LAZY DOG!
-X-Wraptest6: the quick brown fox jumps over the lazy dog. THE QUICK BROWN FOX JUMPS OVER THE LAZY DOG. the quick brown fox jumps over the lazy dog. THE QUICK BROWN FOX JUMPS OVER THE LAZY DOG. the quick brown fox jumps over the lazy dog. THE QUICK BROWN FOX JUMPS OVER THE LAZY DOG. the quick brown fox jumps over the lazy dog. THE QUICK BROWN FOX JUMPS OVER THE LAZY DOG. the quick brown fox jumps over the lazy dog. THE QUICK BROWN FOX JUMPS OVER THE LAZY DOG. the quick brown fox jumps over the lazy dog. THE QUICK BROWN FOX JUMPS OVER THE LAZY DOG. the quick brown fox jumps over the lazy dog. THE QUICK BROWN FOX JUMPS OVER THE LAZY DOG!
Subject: lmtp2nntp testmessage.viasendmail
..
|
|
