OSSP CVS Repository

ossp - Check-in [774]
Not logged in 		[Honeypot]  [Browse]  [Home]  [Login]  [Reports] 
[Search]  [Ticket]  [Timeline] 
  [Patchset]  [Tagging/Branching] 

Check-in Number: 774
Date: 2001-Aug-27 16:25:33 (local)
2001-Aug-27 14:25:33 (UTC)
User:thl
Branch:
Comment: removed ==TRUE and !=TRUE comparisons in favor of ==FALSE, !=FALSE and boolean expressions
Tickets:
Inspections:
Files:
ossp-pkg/lmtp2nntp/lmtp2nntp.c      1.27 -> 1.28     6 inserted, 6 deleted
ossp-pkg/lmtp2nntp/nntp.c      1.15 -> 1.16     1 inserted, 1 deleted
ossp-pkg/lmtp2nntp/lmtp2nntp.c 1.27 -> 1.28 

--- lmtp2nntp.c  2001/08/23 09:12:30     1.27
+++ lmtp2nntp.c  2001/08/27 14:25:33     1.28
@@ -306,7 +306,7 @@
     lmtp_io.select = NULL;
     lmtp_io.read   = trace_read;
     lmtp_io.write  = trace_write;
-    if ((lmtp = lmtp_create(STDIN_FILENO, STDOUT_FILENO, ctx->option_tracing != TRUE ? NULL : &lmtp_io)) == NULL) {
+    if ((lmtp = lmtp_create(STDIN_FILENO, STDOUT_FILENO, ctx->option_tracing ? &lmtp_io : NULL)) == NULL) {
         fprintf(stderr, "%s:Error: Unable to initialize LMTP library\n", progname);
         exit(ERR_EXECUTION);
     }
@@ -396,7 +396,7 @@
      *  RFC1893 2. Status Codes                         5.X.X   Permanent Failure
      *  RFC1893 3.5 Network and Routing Status          X.0.0   Other undefined Status
      */
-    if (ctx->session.lhlo_seen == TRUE) {
+    if (ctx->session.lhlo_seen) {
         res.statuscode = "503";
         res.dsncode    = "5.0.0";
         res.statusmsg  = "Duplicate LHLO.";
@@ -437,7 +437,7 @@
             bOk = FALSE;
         }
         if (bOk && ((ctx->ns[i].nntp = nntp_create(ctx->ns[i].s, ctx->ns[i].s, 
-                                                   ctx->option_tracing != TRUE ? NULL : &nntp_io)) == NULL)) {
+                                                   ctx->option_tracing ? &nntp_io : NULL)) == NULL)) {
             /*fprintf(stderr, "DEBUG: nntp_create failed: %s\n", strerror(errno)); */
             bOk = FALSE;
         }
@@ -631,7 +631,7 @@
      *  RFC1893 2. Status Codes                         5.X.X   Permanent Failure
      *  RFC1893 3.5 Network and Routing Status          X.1.8   Bad sender's system address
      */
-    if (ctx->session.lhlo_seen != TRUE) {
+    if (!ctx->session.lhlo_seen) {
         res.statuscode = "553";
         res.dsncode    = "5.1.8";
         res.statusmsg  = "friendly people say LHLO to open a transmission channel.";
@@ -777,7 +777,7 @@
             lmtp_response(lmtp, &res);
             return LMTP_OK;
         }
-        if (groupmatch(ctx->azGroupargs, ctx->asGroupargs, group) != TRUE) {
+        if (!groupmatch(ctx->azGroupargs, ctx->asGroupargs, group)) {
             res.statuscode = "550";
             res.dsncode    = "5.7.2";
             res.statusmsg  = "unmatched Group.";
@@ -948,7 +948,7 @@
     else { /*                      == GROUPMODE_HEADER */
         cp = ctx->msg->azNewsgroups;
         while (cp != NULL) {
-            if (groupmatch(ctx->azGroupargs, ctx->asGroupargs, cp) != TRUE) {
+            if (!groupmatch(ctx->azGroupargs, ctx->asGroupargs, cp)) {
                 if (argz_next(ctx->msg->azNewsgroups, ctx->msg->asNewsgroups, cp) == NULL) {
                     argz_delete(&ctx->msg->azNewsgroups, &ctx->msg->asNewsgroups, cp);
                     break;

ossp-pkg/lmtp2nntp/nntp.c 1.15 -> 1.16 

--- nntp.c       2001/08/23 09:12:30     1.15
+++ nntp.c       2001/08/27 14:25:33     1.16
@@ -347,7 +347,7 @@
     if (strncmp(line, "240", 3) == 0)
         return NNTP_OK;
 
-    if (nntp->kludgeinn441dup == TRUE) {
+    if (nntp->kludgeinn441dup) {
         if (strncmp(line, "441 435", 7) == 0)
             return NNTP_OK;
     }

CVSTrac 2.0.1