OSSP CVS Repository

ossp - Check-in [739]
Not logged in
[Honeypot]  [Browse]  [Home]  [Login]  [Reports
[Search]  [Ticket]  [Timeline
  [Patchset]  [Tagging/Branching

Check-in Number: 739
Date: 2001-Aug-23 09:50:42 (local)
2001-Aug-23 07:50:42 (UTC)
User:thl
Branch:
Comment: fixed style vs. optimization
Tickets:
Inspections:
Files:
ossp-pkg/lmtp2nntp/nntp.c      1.9 -> 1.10     7 inserted, 6 deleted

ossp-pkg/lmtp2nntp/nntp.c 1.9 -> 1.10

--- nntp.c       2001/08/21 07:40:41     1.9
+++ nntp.c       2001/08/23 07:50:42     1.10
@@ -228,14 +228,14 @@
     nntp_rc_t rc = NNTP_OK;
     char line[NNTP_LINE_MAXLEN];
 
-    /*  RFC 2980
+    /*  RFC2980
      *   
      *  2.3 MODE READER
      *  MODE READER is used by the client to indicate to the server that it is
      *  a news reading client.  Some implementations make use of this
      *  information to reconfigure themselves for better performance in
      *  responding to news reader commands.  This command can be contrasted
-     *  with the SLAVE command in RFC 977, which was not widely implemented.
+     *  with the SLAVE command in RFC0977, which was not widely implemented.
      *  MODE READER was first available in INN.
      *  
      *  2.3.1 Responses
@@ -394,10 +394,11 @@
     if (strncmp(line, "436", 3) == 0)
         return NNTP_DEFER;
 
-    if (   (strncmp(line, "437", 3) == 0) /*FIXME style vs. optimization - redundant lines */
-        || (strncmp(line, "480", 3) == 0)
-        || (strncmp(line, "335", 3) != 0)
-          )
+    if (   (strncmp(line, "437", 3) == 0)
+        || (strncmp(line, "480", 3) == 0))
+        return NNTP_ERR_POST;
+
+    if (strncmp(line, "335", 3) != 0)
         return NNTP_ERR_POST;
 
     if ((rc = nntp->io.write(nntp->wfd, msg->cpMsg, strlen(msg->cpMsg))) < 0) /*FIXME while() wrapper around write required */

CVSTrac 2.0.1