OSSP CVS Repository

ossp - Check-in [5679]
Not logged in
[Honeypot]  [Browse]  [Home]  [Login]  [Reports
[Search]  [Ticket]  [Timeline
  [Patchset]  [Tagging/Branching

Check-in Number: 5679
Date: 2007-Jan-01 19:29:18 (local)
2007-Jan-01 18:29:18 (UTC)
User:rse
Branch:
Comment: Fix sanity check on "mm_global" variable in MM_permission().

Submitted by: Michael Durket <durket@hw-durket.stanford.edu>

Tickets:
#149 Incorrect test in MM_permission
Inspections:
Files:
ossp-pkg/mm/ChangeLog      1.61 -> 1.62     3 inserted, 0 deleted
ossp-pkg/mm/THANKS      1.19 -> 1.20     1 inserted, 0 deleted
ossp-pkg/mm/mm_global.c      1.17 -> 1.18     1 inserted, 1 deleted

ossp-pkg/mm/ChangeLog 1.61 -> 1.62

--- ChangeLog    2007/01/01 18:26:34     1.61
+++ ChangeLog    2007/01/01 18:29:18     1.62
@@ -11,6 +11,9 @@
 
  Changes between 1.4.2 and 1.4.3 (15-Aug-2006 to 01-Jan-2007)
 
+  *) Fix sanity check on "mm_global" variable in MM_permission().
+     [Michael Durket <durket@hw-durket.stanford.edu>]
+
   *) Updated all copyright messages for year 2007.
      [Ralf S. Engelschall]
 


ossp-pkg/mm/THANKS 1.19 -> 1.20

--- THANKS       2006/11/20 19:52:14     1.19
+++ THANKS       2007/01/01 18:29:18     1.20
@@ -24,6 +24,7 @@
     o  Neil Conway                 <neilc@samurai.com>
     o  Alexander Demenchuk         <alder@untech.com>
     o  Jason Dillon                <jason@planet57.com>
+    o  Michael Durket              <durket@hw-durket.stanford.edu>
     o  Alexander Farber            <farber@cpan.org>
     o  Joe France                  <france@sysar.com>
     o  Richard Furda               <riso@best.ca>


ossp-pkg/mm/mm_global.c 1.17 -> 1.18

--- mm_global.c  2007/01/01 18:26:34     1.17
+++ mm_global.c  2007/01/01 18:29:19     1.18
@@ -61,7 +61,7 @@
 
 int MM_permission(mode_t mode, uid_t owner, gid_t group)
 {
-    if (mm_global != NULL)
+    if (mm_global == NULL)
         return -1;
     return mm_permission(mm_global, mode, owner, group);
 }

CVSTrac 2.0.1