OSSP CVS Repository

ossp - Check-in [4579]
Not logged in
[Honeypot]  [Browse]  [Home]  [Login]  [Reports
[Search]  [Ticket]  [Timeline
  [Patchset]  [Tagging/Branching

Check-in Number: 4579
Date: 2004-May-10 20:01:03 (local)
2004-May-10 18:01:03 (UTC)
User:rse
Branch:
Comment: Fixed two more warnings about undefined variables.

Submitted by: Michael Schloh von Bennewitz

Tickets:
Inspections:
Files:
ossp-pkg/shiela/ChangeLog      1.46 -> 1.47     3 inserted, 0 deleted
ossp-pkg/shiela/THANKS      1.4 -> 1.5     4 inserted, 3 deleted
ossp-pkg/shiela/shiela.pl      1.58 -> 1.59     2 inserted, 2 deleted

ossp-pkg/shiela/ChangeLog 1.46 -> 1.47

--- ChangeLog    2004/05/10 17:57:48     1.46
+++ ChangeLog    2004/05/10 18:01:03     1.47
@@ -15,6 +15,9 @@
       lines in case of added files.
       [Ralf S. Engelschall]
 
+   *) Fixed two more warnings about undefined variables.
+      [Ralf S. Engelschall, Michael Schloh von Bennewitz]
+
   Changes between 1.1.0 and 1.1.1 (07-May-2002 to 10-May-2004):
 
    *) Workaround a syntax problem under Solaris /bin/sh.


ossp-pkg/shiela/THANKS 1.4 -> 1.5

--- THANKS       2004/05/05 13:18:47     1.4
+++ THANKS       2004/05/10 18:01:03     1.5
@@ -12,9 +12,10 @@
   Credit has to be given to the following people who contributed ideas,
   stuff, bugfixes, hints etc. (in alphabetical order):
 
-  o Denis Barbier            <barbier@imacs.polytechnique.fr>
-  o Markus Sander            <msander@de.cw.com>
-  o Christoph Schug          <chris@schug.net>
+  o Denis Barbier               <barbier@imacs.polytechnique.fr>
+  o Markus Sander               <msander@de.cw.com>
+  o Michael Schloh v. Bennewitz <michael.schloh@cw.com>
+  o Christoph Schug             <chris@schug.net>
 
   ...and all other OSSP shiela users who gave me feedback but I've forgot.
 


ossp-pkg/shiela/shiela.pl 1.58 -> 1.59

--- shiela.pl    2004/05/10 17:57:48     1.58
+++ shiela.pl    2004/05/10 18:01:03     1.59
@@ -1440,7 +1440,7 @@
     $RT->{cvsop} = 'commit-file';
 
     #   handle special invocation under `cvs add <dir>'
-    if ($PA->{ARG}->[1] eq '- New directory') { # see CVS' src/add.c
+    if (defined($PA->{ARG}->[1]) and $PA->{ARG}->[1] eq '- New directory') { # see CVS' src/add.c
         #   Hmmm... we always just deal with files in OSSP shiela, so there
         #   is no obvious and consistent way to deal now with only a
         #   plain directory. And there is also no log message provided
@@ -1456,7 +1456,7 @@
     #   CVS only calls us inside the loginfo hook and never in the
     #   commitinfo hook before. Additionally CVS doesn't provide us with
     #   the %{sVvto} information :(
-    if ($PA->{ARG}->[1] eq '- Imported sources') { # see CVS' src/import.c
+    if (defined($PA->{ARG}->[1]) and $PA->{ARG}->[1] eq '- Imported sources') { # see CVS' src/import.c
         #   I = ignored
         #   L = link (=error),
         #   N = new file

CVSTrac 2.0.1