OSSP CVS Repository

ossp - Check-in [3910]
Not logged in
[Honeypot]  [Browse]  [Home]  [Login]  [Reports
[Search]  [Ticket]  [Timeline
  [Patchset]  [Tagging/Branching

Check-in Number: 3910
Date: 2002-Dec-20 16:13:52 (local)
2002-Dec-20 15:13:52 (UTC)
User:ms
Branch:
Comment: Fixed data loading bug, causing overwriting of last row with first row's data.
Tickets:
Inspections:
Files:
ossp-pkg/as/as-gui/TODO      1.57 -> 1.58     4 inserted, 7 deleted
ossp-pkg/as/as-gui/as_assist.cpp      1.77 -> 1.78     3 inserted, 2 deleted
ossp-pkg/as/as-gui/as_dataop.cpp      1.30 -> 1.31     0 inserted, 1 deleted
ossp-pkg/as/as-gui/as_slot.cpp      1.73 -> 1.74     1 inserted, 8 deleted

ossp-pkg/as/as-gui/TODO 1.57 -> 1.58

--- TODO 2002/12/20 13:25:04     1.57
+++ TODO 2002/12/20 15:13:52     1.58
@@ -27,19 +27,16 @@
 After every result write a status bar message
 On sort, selection should move with swapped rows
 On multiple selection, no text should appear in edit ctrls
+Make consistent setEdition(), setDirty() default parameters
 
-Bugs
-----
+Bugs (? = unverified)
+---------------------
 Overidden paintCell() might not work when called asynchronously?
 Sometimes a click on add or delete toolbar button is ignored?
+When multiple new rows are added sometimes wrong row shading?
 Disabled actions still show enabled icons in menu popups
 Pressing escape on task data cells does not exit edit mode
 
-When multiple new rows are added sometimes wrong row shading
-  Verified: Start prog, newDoc, addRow five times
-On load, first row is duplicated and appended to end of matrix
-  Or: last row is duplicated, prepended to matrix, replaces a row there
-
 Nice to have
 ------------
 Implement an unlimited and generic undo and redo buffer class


ossp-pkg/as/as-gui/as_assist.cpp 1.77 -> 1.78

--- as_assist.cpp        2002/12/20 13:25:04     1.77
+++ as_assist.cpp        2002/12/20 15:13:52     1.78
@@ -918,6 +918,7 @@
 //
 void Titraqform::enableIface(bool bTurned)
 {
+    // FIXME: Does not belong here, so relocate
     if (!bTurned)
         m_pMaintable->setNumRows(0);    // Remove table data
 
@@ -947,6 +948,6 @@
     m_pPasteact->setEnabled(bTurned);
 
     // Unconditional settings
-    this->updEdit(0, 0);            // Update edit controls
-    m_pMaintable->setDirty(false);  // Reset to clean data
+    this->updEdit(m_pMaintable->currentRow(), 0);   // Update edit controls
+    m_pMaintable->setDirty(false);                  // Reset to clean data
 }


ossp-pkg/as/as-gui/as_dataop.cpp 1.30 -> 1.31

--- as_dataop.cpp        2002/12/19 20:46:26     1.30
+++ as_dataop.cpp        2002/12/20 15:13:52     1.31
@@ -41,7 +41,6 @@
 #include "as_gfx/staterr.xpm"   // static const char *s_kpcStaterror_xpm[]
 #include "as_gfx/statwrn.xpm"   // static const char *s_kpcStatwarn_xpm[]
 
-#include <iostream>
 
 //
 // Convenience method to load accounts from a file


ossp-pkg/as/as-gui/as_slot.cpp 1.73 -> 1.74

--- as_slot.cpp  2002/12/19 20:46:26     1.73
+++ as_slot.cpp  2002/12/20 15:13:52     1.74
@@ -262,14 +262,7 @@
     this->setCaption(trUtf8("No file name"));
     m_pStatbar->message(trUtf8("New document"), 4000);
     this->setFilename("");
-
-    // Reset widget text of edit controls
-    m_pDateedit->setDate(*m_pDatezero);
-    m_pStarttime->setTime(QTime::QTime(0, 0));
-    m_pEndtime->setTime(QTime::QTime(0, 0));
-    m_pAmount->setText(NULL);
-    m_pTasks->setCurrentText(NULL);
-    m_pRemark->setText(NULL);
+    this->updEdit(0, 0);                // Update edit controls
 }
 
 //

CVSTrac 2.0.1