OSSP CVS Repository

ossp - Check-in [3041]
Not logged in
[Honeypot]  [Browse]  [Home]  [Login]  [Reports
[Search]  [Ticket]  [Timeline
  [Patchset]  [Tagging/Branching

Check-in Number: 3041
Date: 2002-Dec-23 13:13:27 (local)
2002-Dec-23 12:13:27 (UTC)
User:rse
Branch:
Comment: CVS since 1.11.2 allows verifymsg-hooked scripts to actually change the message and reads the contents back. So we do no longer require CVS with RSE patches applied for the verifymsg hook to be activated.
Tickets:
Inspections:
Files:
ossp-pkg/shiela/ChangeLog      1.31 -> 1.32     6 inserted, 0 deleted
ossp-pkg/shiela/shiela.pl      1.43 -> 1.44     6 inserted, 9 deleted

ossp-pkg/shiela/ChangeLog 1.31 -> 1.32

--- ChangeLog    2002/12/23 12:08:35     1.31
+++ ChangeLog    2002/12/23 12:13:27     1.32
@@ -11,6 +11,12 @@
 
   Changes between 1.0.2 and 1.0.3 (23-Dec-2002 to 23-Dec-2002):
 
+   *) CVS since 1.11.2 allows verifymsg-hooked scripts to actually
+      change the message and reads the contents back. So we do no longer
+      require CVS with RSE patches applied for the verifymsg hook to be
+      activated.
+      [Ralf S. Engelschall]
+
    *) Added a section to the shiela-install manual page about the
       internal processing steps performed by CVS. Additionally mention
       the details about the CVS version with RSE patches applied.


ossp-pkg/shiela/shiela.pl 1.43 -> 1.44

--- shiela.pl    2002/12/23 11:50:09     1.43
+++ shiela.pl    2002/12/23 12:13:27     1.44
@@ -1310,12 +1310,12 @@
 ##
 ##  VERIFYMSG HOOK
 ##
-##  We hook into CVS via `commitinfo' to post-process log messages.
-##  The intention is to sanitise the results of what the user may have
-##  `done' while editing the commit log message. If CVS is a standard
-##  version, this check is advisory only. If CVS contains the RSE
-##  patches, the log message is changed and CVS reads back the contents
-##  so that this script can actually make changes.
+##  We hook into CVS via `verifymsg' to post-process log messages. The
+##  intention is to sanitise the results of what the user may have
+##  `done' while editing the commit log message. If CVS is an anchient
+##  version, this check is advisory only. If CVS is at least version
+##  1.11.2, the log message can be changed and CVS actually reads back
+##  the contents so that this script can actually make changes.
 ##
 ##  We are called by CVS with a single argument: the path to the log
 ##  message file.
@@ -1326,9 +1326,6 @@
     my ($PA, $RT, $CF) = @_;
     my $rv = 0;
 
-    #   we require the RSE patches for operation
-    return $rv if (not $RT->{cvsrse});
-
     #   suck in the log message
     my $logfile = $PA->{ARG}->[0];
     my $io = new IO::File "<$logfile"

CVSTrac 2.0.1