OSSP CVS Repository

ossp - Check-in [2751]
Not logged in
[Honeypot]  [Browse]  [Home]  [Login]  [Reports
[Search]  [Ticket]  [Timeline
  [Patchset]  [Tagging/Branching

Check-in Number: 2751
Date: 2002-Nov-07 13:44:12 (local)
2002-Nov-07 12:44:12 (UTC)
User:rse
Branch:
Comment: Make sure that "va_list" variables are not compared against NULL because this is not possible on all platforms.
Tickets:
Inspections:
Files:
ossp-pkg/sa/ChangeLog      1.13 -> 1.14     4 inserted, 0 deleted
ossp-pkg/sa/sa.c      1.69 -> 1.70     2 inserted, 2 deleted
ossp-pkg/sa/ts.c      1.5 -> 1.6     2 inserted, 2 deleted

ossp-pkg/sa/ChangeLog 1.13 -> 1.14

--- ChangeLog    2002/11/07 12:17:06     1.13
+++ ChangeLog    2002/11/07 12:44:12     1.14
@@ -13,6 +13,10 @@
 
   Changes between 1.0.0 and 1.0.1 (01-Nov-2002 to xx-Nov-2002)
 
+   o Make sure that "va_list" variables are not compared against NULL
+     because this is not possible on all platforms.
+     [Ralf S. Engelschall]
+
    o Ported to brain-dead OpenUNIX where shutdown(3)'s SHUT_XX values
      are not easily available and where variables named sa_len conflict
      with structure fields in vendor headers.


ossp-pkg/sa/sa.c 1.69 -> 1.70

--- sa.c 2002/11/07 12:17:06     1.69
+++ sa.c 2002/11/07 12:44:12     1.70
@@ -318,7 +318,7 @@
     int n;
     int bytes;
 
-    if (format == NULL || ap == NULL)
+    if (format == NULL)
         return -1;
     bytes = 0;
     while (*format != '\0') {
@@ -400,7 +400,7 @@
     int n;
     sa_mvsnprintf_cb_t ctx;
 
-    if (format == NULL || ap == NULL)
+    if (format == NULL)
         return -1;
     if (buffer != NULL && bufsize == 0)
         return -1;


ossp-pkg/sa/ts.c 1.5 -> 1.6

--- ts.c 2002/03/08 23:08:39     1.5
+++ ts.c 2002/11/07 12:44:12     1.6
@@ -126,7 +126,7 @@
     int n;
     int bytes;
 
-    if (format == NULL || ap == NULL)
+    if (format == NULL)
         return -1;
     bytes = 0;
     while (*format != '\0') {
@@ -200,7 +200,7 @@
     int n;
     va_list ap2;
 
-    if (format == NULL || ap == NULL)
+    if (format == NULL)
         return NULL;
     ap2 = ap;
     if ((n = ts_suite_mvxprintf(NULL, 0, format, ap)) == -1)

CVSTrac 2.0.1